Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Redesign redactions #4484

Merged
merged 12 commits into from
May 8, 2020
Merged

Redesign redactions #4484

merged 12 commits into from
May 8, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Apr 24, 2020 •
edited
Loading

@t3chguy
Redesign redactions
e16f511 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
first draft of Redaction ELS
d3b0e00 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Merge branches 'develop' and 't3chguy/redaction_redesign' of github.c…
9dd204d 
…om:matrix-org/matrix-react-sdk into t3chguy/redaction_redesign
@t3chguy
fix flashing by ""
a399b10 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
remove RedactedGrouper for now
83a4558 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
clean ups
c787009 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
more tidying
a5830c2 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
null-guards
3e35cff 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy mentioned this pull request Apr 27, 2020
Merged
@t3chguy t3chguy requested a review from a team April 27, 2020 22:55
@t3chguy t3chguy marked this pull request as ready for review April 27, 2020 22:56
@t3chguy t3chguy requested a review from a team April 27, 2020 23:04
nadonomy
nadonomy suggested changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@nadonomy nadonomy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@t3chguy from the screenshot it looks like the icon & text could benefit from a bit more space, is there an ad hoc build somewhere where this can be tested?

@dbkr dbkr requested review from dbkr and removed request for a team April 29, 2020 10:11
@t3chguy
Merge branches 'develop' and 't3chguy/redaction_redesign' of github.c…
f0085a9 
…om:matrix-org/matrix-react-sdk into t3chguy/redaction_redesign
@t3chguy
Copy link
Member Author

t3chguy commented May 7, 2020

@nadonomy - https://riots.im/adhoc/redactions1/

@t3chguy
fix unrelated tautology
7c1ac7a 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Update padding-left to 20px as per Nad's iteration
4d6cd3c 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Copy link
Member Author

t3chguy commented May 7, 2020

image

@t3chguy t3chguy requested a review from nadonomy May 7, 2020 14:41
nadonomy
nadonomy approved these changes May 7, 2020
View reviewed changes
Copy link
Contributor

@nadonomy nadonomy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@t3chguy
Merge branches 'develop' and 't3chguy/redaction_redesign' of github.c…
dc65c87 
…om:matrix-org/matrix-react-sdk into t3chguy/redaction_redesign
@t3chguy t3chguy merged commit 347e3a0 into develop May 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbkr dbkr dbkr approved these changes

@nadonomy nadonomy nadonomy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Redacted messages (and potentially other types) visual design
3 participants
@t3chguy @dbkr @nadonomy