This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix popout support for jitsi widgets #4319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dbkr
commented
Apr 1, 2020
dbkr
commented
- Move URL templating into AppTile so we can use different URLs for iframed widgets and popped-out widgets
- Remove now-unused get-config call from the widget API
Move the URL processing into AppTile so that the widget can have a URL used for embedding in the page and a separate one for popping out into a browser.
which is no longer necessary now the jitsi wrapper has its own external-api script
The popout can't be assumed to have the widget API available, so just leave these params out.
jryans
suggested changes
Apr 1, 2020
jryans
approved these changes
Apr 1, 2020
This was referenced Apr 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.