Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix alignment of e2e icon in userinfo and expose full displayname in title #4312

Merged
merged 4 commits into from
Apr 3, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Mar 31, 2020

@t3chguy t3chguy requested review from a team March 31, 2020 15:15
Copy link
Contributor

@nadonomy nadonomy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@t3chguy it looks like the icon is misaligned vertically— not sure what it's aligning to at the moment but vertically it should be centre aligned with the text.

Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm code wise

@t3chguy
Copy link
Member Author

t3chguy commented Apr 1, 2020

@nadonomy I think it is vertically aligned, the sample image doesn't show anything going below the text baseline e.g qpy

image

Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy requested a review from bwindels April 1, 2020 16:18
@t3chguy
Copy link
Member Author

t3chguy commented Apr 1, 2020

(sorry small structural improvement)

@t3chguy t3chguy merged commit da89391 into develop Apr 3, 2020
@t3chguy t3chguy deleted the t3chguy/xsigning/fix_userinfo_e2eicon branch April 27, 2020 17:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User profile: shield and display name should be on same line
3 participants