Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

blank out UserInfo avatar when changing between members #4289

Merged
merged 1 commit into from
Mar 27, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Mar 27, 2020

MemberAvatar doesn't blank out on props changes to rip it out and render from scratch on a member change to cause a blank to show instead of the old avatar.

Fixes element-hq/element-web#12899

@t3chguy t3chguy requested a review from a team March 27, 2020 10:02
Copy link
Contributor

@bwindels bwindels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

@t3chguy t3chguy merged commit cf4f595 into develop Mar 27, 2020
@t3chguy t3chguy deleted the t3chguy/userInfo_avatar branch April 27, 2020 17:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clicking on another user to open their profile shows the last user's avatar
2 participants