Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Room Directory Explore Servers redesign #4209

Merged
merged 19 commits into from
Mar 18, 2020
Merged

Room Directory Explore Servers redesign #4209

merged 19 commits into from
Mar 18, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Mar 13, 2020 •
edited
Loading

Fixes element-hq/element-web#3769
Fixes element-hq/element-web#3770
Fixes element-hq/element-web#5194
Fixes element-hq/element-web#6260
Fixes element-hq/element-web#12495
Fixes element-hq/element-web#12497

  • Implement design to match Figma
  • Implement way to add servers
  • Implement way to remove added servers
  • Improve accessibility
  • Switch to Field in TextInputDialog
  • Use validations to check that the server the user has entered has a public working room directory
  • Don't use a green stroke on the dropdown
  • Ensure hovers don't over-occlude out of the dropdown (currently happening on + Add a server)
  • Fix widths of the sub-dialogs
  • Decorate results with network as per Figma This is being deferred due to complexity.
  • Disable [Add] button by default, enable after validation is successful We decided against this

image
image
image
image

Test build available at: https://riots.im/adhoc/servers5/

Remaining work:

  • Nad needs to confirm Server address vs Server name
  • Investigate local echo as settings are slow :(

t3chguy added 8 commits March 10, 2020 23:11
@t3chguy
Tweak padding to match Figma
5c58203 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Initial attempt to redesign explore servers in room directory
86e53ea 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
i18n
dd4dc05 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
clean up
343403f 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
allow it to expand for longer content
359b07b 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
remove erroneous margin
642dd08 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
add missing asset
3628fd2 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
fix styling of server name in handle
5a27fa7 
Signed-off-by: Michael Telatynski <[email protected]>
@BillCarsonFr BillCarsonFr mentioned this pull request Mar 13, 2020
Open
2 tasks
t3chguy added 6 commits March 13, 2020 14:19
@t3chguy
update font sizes
9237cf9 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Improve accessibility
af368a4 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
delint
401d85e 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
no need to await here as settings take a while to effect, we watch th…
8433218 
…em elsewhere

Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
fix styling mistakes
4de0e21 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Add Field validation to TextInputDialog
ee16596 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy requested review from a team March 13, 2020 17:37
@t3chguy t3chguy marked this pull request as ready for review March 13, 2020 17:37
t3chguy added 5 commits March 16, 2020 11:45
@t3chguy
s/Server address/Server name/
6f27c4c 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Fix styling of NetworkDropdown dialogs
82a37ba 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
improve width
454b324 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Add local-echo
eabaf58 
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy
Fix missed copy
78543da 
Signed-off-by: Michael Telatynski <[email protected]>
@dbkr dbkr requested review from dbkr and removed request for a team March 18, 2020 09:54
dbkr
dbkr approved these changes Mar 18, 2020
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks plausible!

src/components/views/directory/NetworkDropdown.js Show resolved Hide resolved
nadonomy
nadonomy approved these changes Mar 18, 2020
View reviewed changes
Copy link
Contributor

@nadonomy nadonomy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, looking forward to spending more time on this in future, but a welcome improvement for the short term. :)

@t3chguy t3chguy merged commit ef79492 into develop Mar 18, 2020
@t3chguy t3chguy deleted the t3chguy/redesign/room_directory branch April 27, 2020 17:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nadonomy nadonomy nadonomy approved these changes

@dbkr dbkr dbkr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@t3chguy @dbkr @nadonomy