This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Suggest the server's results as lower quality in the invite dialog #4149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a quick win for fixing element-hq/element-web#12488 but might not be a long-term solution. Idea is to see how this feels and go from there, which may mean scoring the results again to filter them in or altering the debounce timers.
turt2live
changed the title
dbkr
reviewed
Mar 2, 2020
| const hasMixins = this.state.serverResultsMixin || this.state.threepidResultsMixin; | ||
| if (this.state.filterText && hasMixins && kind === 'suggestions') { | ||
| // We don't want to duplicate members though, so just exclude anyone we've already seen. | ||
| const notAlreadyExists = (u: Member): boolean => { | ||
| return !sourceMembers.some(m => m.userId === u.userId) | ||
| && !additionalMembers.some(m => m.userId === u.userId); | ||
| && !priorityAdditionalMembers.some(m => m.userId === u.userId) | ||
| && !otherAdditionalMembers.some(m => m.userId === u.userId); |
There was a problem hiding this comment.
These are just declared above the if block - I'm not seeing when they'd ever be non-empty?
There was a problem hiding this comment.
Sanity more than anything, the otherAdditionalMembers array would be populated when priorityAdditionalMembers is defined. To prevent future bugs, we just check both much like we were doing before.
dbkr
approved these changes
Mar 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a quick win for fixing element-hq/element-web#12488 but might not be a long-term solution. Idea is to see how this feels and go from there, which may mean scoring the results again to filter them in or altering the debounce timers.
Fixes element-hq/element-web#12488