This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Reword the status for the currently indexing rooms. #4084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
approved these changes
Feb 18, 2020
|
There's still an ongoing discussion on the exact wording. Perhaps @nadonomy can chime in quickly? |
|
@poljar apologies this slipped through the crack in the review queue, I've made some changes to my workflow to avoid this happening again. :) Will add comments in element-hq/element-web#12334 so we have a better canonical place for discussion. |
…ndexing rooms." This reverts commit 7d6569a.
This reflects now the latests design on Figma.
poljar
force-pushed
the
poljar/eventindex-stats-wording
branch
from
7d6569a to
6938982
Compare
nadonomy
approved these changes
Mar 6, 2020
There was a problem hiding this comment.
Based on the discussion in element-hq/element-web#12334 & latest screenshots this LGTM.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hopes to address element-hq/element-web#12334. There's still no consensus on what it should exactly be but pushed here to start a discussion.
Pictures of the changes can be found on the issue.
Fixes element-hq/element-web#12334