Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add setting to allow hiding of typing indicator #4047

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Add setting to allow hiding of typing indicator #4047

merged 1 commit into from
Feb 10, 2020

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Feb 9, 2020 •
edited
Loading

Fixes element-hq/element-web#7283
Supersedes #3494 which did not watch the setting and had some unrelated stuff like invertedSettingsName

Confirmed by Matthew (on behalf of product) as desired

@t3chguy t3chguy requested a review from a team February 9, 2020 00:05
jryans
jryans approved these changes Feb 10, 2020
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use title case in PR title and ensure it's comprehensible for the changelog.

Looks great otherwise!

@t3chguy t3chguy changed the title allow hiding of who is typing tile Allow hiding of typing indicator Feb 10, 2020
@t3chguy t3chguy changed the title Allow hiding of typing indicator Add setting to allow hiding of typing indicator Feb 10, 2020
@t3chguy t3chguy merged commit b9db0ad into develop Feb 10, 2020
@t3chguy t3chguy deleted the t3chguy/hide_typing_notifs branch April 27, 2020 17:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jryans jryans jryans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add option to disable typing notification
2 participants
@t3chguy @jryans