This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Use Sets instead of array scans and simplify hiding of invalid users when inviting #4004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to invite Signed-off-by: Michael Telatynski <[email protected]>
|
Is there a bug here or is this just cleanup? |
|
As the first post says: |
t3chguy
commented
Jan 30, 2020
| @@ -456,7 +453,7 @@ export default class InviteDialog extends React.PureComponent { | |||
| const events = room.getLiveTimeline().getEvents(); // timelines are most recent last | |||
| for (let i = events.length - 1; i >= Math.max(0, events.length - maxMessagesConsidered); i--) { | |||
| const ev = events[i]; | |||
| if (excludedUserIds.includes(ev.getSender())) { | |||
| if (excludedTargetIds.has(ev.getSender())) { | |||
There was a problem hiding this comment.
this was not skipping on the members already in the room
|
I honestly don't see "Fixes XXXX" unless it is bold, sorry :( |
turt2live
approved these changes
Jan 30, 2020
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Set has closer to |
turt2live
approved these changes
Jan 30, 2020
|
sure, but it's still just as fast. It's too small of a dataset to really make much of a difference. |
|
ah its limited at 200, fair enough |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The difference between
excludedTargetIdsandexcludedUserIdsmay be lost on me :(it was pruning out the
excludedTargetIdsthen adding anylastSpokeusers back in anyway to suggestionsSeeing so many nested loops and
.includescalls hurt me deeply so I flipped things over to use ES6 Sets.Fixes element-hq/element-web#12051
Signed-off-by: Michael Telatynski [email protected]