This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix arrows keys moving through edit history #3874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Different fix that fixes element-hq/element-web#11817 by setting the flag before the callback rather than having the update method set the flag. Regressed in #3842 Fixes element-hq/element-web#11917
bwindels
suggested changes
Jan 20, 2020
There was a problem hiding this comment.
1 thing to address, otherwise lgtm. Just to confirm 3 things happen in this PR:
- revert Fix timing of when Composer considers itself to be modified #3842 (as discussed in riot web internal, setting the flag in the dom event handlers seems a bit clearer)
- add missing
this._modifiedFlag = true;when cutting - put the
this._modifiedFlag = true;in_insertText(used for adding newlines) before updating the model, to fix the issue originally resolved in Fix timing of when Composer considers itself to be modified #3842
|
Yeah, I originally put it into the cut code path when reverting the patch as it didn't revert cleanly, but it turns out that one came from paste. |
bwindels
approved these changes
Jan 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different fix that fixes element-hq/element-web#11817
by setting the flag before the callback rather than having the update
method set the flag.
Regressed in #3842
Fixes element-hq/element-web#11917