This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 827
Room header & message box shields now reflect cross-signing state #3850
Merged
foldleft
merged 7 commits into
develop
from
zip/11225-shields-distinguish-encrypt-from-verify
Jan 17, 2020
Merged
Room header & message box shields now reflect cross-signing state #3850
foldleft
merged 7 commits into
develop
from
zip/11225-shields-distinguish-encrypt-from-verify
Jan 17, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in less alarmed tones
@foldleft, please add pictures in the PR body above 😄 |
…distinguish-encrypt-from-verify
dbkr
reviewed
Jan 16, 2020
dbkr
reviewed
Jan 16, 2020
dbkr
reviewed
Jan 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just one last thing :)
dbkr
approved these changes
Jan 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
foldleft
deleted the
zip/11225-shields-distinguish-encrypt-from-verify
branch
January 17, 2020 13:50
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user has cross-signing enabled, the room header and input field shields now represent encryption state slightly differently:
This addresses part, but not all, of element-hq/element-web#11225
---
---
---
---
---