This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Remove all text when cutting in the composer #3848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous function did in fact remove the elements, but left the model thinking there was a zero-length string. This approach deletes the text from the model and the DOM, resulting in the placeholder being shown when cutting all the text. Part of element-hq/element-web#11378
|
Actually this won't work if you only highlight part of the text and cut it - you lose the whole message. |
This gives people the option of cutting parts or all of their message.
We get an NPE when the user cuts their entire message, and this fixes it.
|
This'll probably fix element-hq/element-web#11883 |
|
it does |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous function did in fact remove the elements, but left the model thinking there was a zero-length string. This approach replaces the selection with empty text, making the model more accurate given the change in text goes through the model eventually.
Part of element-hq/element-web#11378
Fixes element-hq/element-web#11883