-
-
Notifications
You must be signed in to change notification settings - Fork 827
Conversation
Great, I added @nadonomy as an extra reviewer for the design side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code-wise LGTM, deferring to Nad for design review
According to our new process experiment discussed yesterday, now that it's guarded by a labs flag, we have the option of skipping design review on the PR. (I'll leave it to @foldleft to decide whether to wait for it or not.) |
Is it guarded by the same labs flag as the general cross-signing one? If so then I don't see a problem with merging. When we move cross-signing from /develop to production we'll be doing rounds of small visual polish and there'll be opportunity to action the required polish then. |
Yes, this and anything cross-signing related are all using a single labs flag. (The only outlier is the shield in the room header which already shipped for all in December, but going forward at least, all should be guarded.) |
Fixes element-hq/element-web#11832
Encrypted, locked:
Unencrypted, locked:
Public room: