This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Don't allow upgrade from untrusted key backup. #3822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we trust the key backup at upgrade time then we can sign it so key backup will work automatically when cross-signing is trusted. If we don't sign it at this point we'll end up with cross-signing and key backup set up but key backup untrusted by the cross-signing key which is a bit of a broken situation. With matrix-org/matrix-js-sdk#1144 fixes element-hq/element-web#11747
jryans
suggested changes
Jan 13, 2020
src/async-components/views/dialogs/secretstorage/CreateSecretStorageDialog.js
Outdated
Show resolved
Hide resolved
src/async-components/views/dialogs/secretstorage/CreateSecretStorageDialog.js
Outdated
Show resolved
Hide resolved
src/async-components/views/dialogs/secretstorage/CreateSecretStorageDialog.js
Outdated
Show resolved
Hide resolved
Co-Authored-By: J. Ryan Stinnett <[email protected]>
jryans
approved these changes
Jan 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we trust the key backup at upgrade time then we can sign it so
key backup will work automatically when cross-signing is trusted.
If we don't sign it at this point we'll end up with cross-signing
and key backup set up but key backup untrusted by the cross-signing
key which is a bit of a broken situation.
With matrix-org/matrix-js-sdk#1144 fixes
element-hq/element-web#11747