This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Strip all variation selectors on emoji #3814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...when inserting into or looking up in the unicode to emoji map. This broke with emojibase 4.2.0 which changed the type of a whole load of emojis to 'text' when previously they were 'emoji'. This caused them to get the 'text' variant of the unicode string which has the text variation selector (15) appended instead of the emoji variation selector (16). We were only stripping the emoji selector, so upgrading to 4.2.0 caused riot to fail to find the heart in the unicode map, which therefore prevented the app from starting.
t3chguy
reviewed
Jan 7, 2020
src/emoji.js
Outdated
| ret += str.charAt(i); | ||
| } | ||
| } | ||
| return ret; |
There was a problem hiding this comment.
can this not just be done using a regex unicode character range?
There was a problem hiding this comment.
Good question: I'm not sure as I'd have to look at whether js regexes match by UTF-16 character code or by codepoint, which I suspect depends on whether you use an old style regex or an ES6 style 'u' regex?
There was a problem hiding this comment.
nm: a regex is indeed fine. My code wasn't though because I had an 'and' when I needed an 'or'.
and my loop did not because I meant 'or', not 'and'
t3chguy
reviewed
Jan 7, 2020
t3chguy
approved these changes
Jan 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...when inserting into or looking up in the unicode to emoji map.
This broke with emojibase 4.2.0 which changed the type of a whole
load of emojis to 'text' when previously they were 'emoji'. This
caused them to get the 'text' variant of the unicode string which
has the text variation selector (15) appended instead of the emoji
variation selector (16). We were only stripping the emoji selector,
so upgrading to 4.2.0 caused riot to fail to find the heart in the
unicode map, which therefore prevented the app from starting.