This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Use the new js-sdk imports and import from src #3763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A failing build is not surprising - this will be fixed in a future PR before the feature branch goes to develop. |
Because ES6 and such.
turt2live
changed the title
This was referenced Dec 23, 2019
dbkr
approved these changes
Jan 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is against
travis/sourcemapsfor safety.Split from #3744
Based upon #3762 - see pull/3762/head...pull/3763/head for real diff
We import from
src/because this layer (and riot-web) is capable of compiling it, so for better type safety and more accurate source maps let's use the real thing.This PR and others in the series have their overview covered here: https://gist.github.com/turt2live/a3fc7c9712b8ef0f1f758611aa33382d