This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Change ref handling in TextualBody to prevent it parsing generated nodes #3711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove unused paths Signed-off-by: Michael Telatynski <[email protected]>
….com:matrix-org/matrix-react-sdk into t3chguy/clean_up_TextualBody � Conflicts: � src/components/views/messages/TextualBody.js
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
turt2live
reviewed
Jan 9, 2020
turt2live
approved these changes
Jan 9, 2020
| @@ -261,7 +261,7 @@ const Pill = createReactClass({ | |||
| } | |||
|
|
|||
| const classes = classNames("mx_Pill", pillClass, { | |||
| "mx_UserPill_me": userId === MatrixClientPeg.get().credentials.userId, | |||
| "mx_UserPill_me": userId === MatrixClientPeg.get().getUserId(), | |||
There was a problem hiding this comment.
This is the second unrelated change in this PR - please try to keep these out for future PRs. Personally I don't mind having one vaguely related thing in the PR, but after a couple it starts to feel like false advertising on the PR.
There was a problem hiding this comment.
The change is not unrelated, it was to simplify stubbing for the test, any and all changes in this PR are related either to the change or testing it.
There was a problem hiding this comment.
things like this should be pointed out so tired eyes don't miss them :(
Co-Authored-By: Travis Ralston <[email protected]>
….com:matrix-org/matrix-react-sdk into t3chguy/clean_up_TextualBody � Conflicts: � yarn.lock
Signed-off-by: Michael Telatynski <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#11627
Instead of passing in the entire event span and only looking at its children, only look at the event body and that way we don't end up re-parsing the url previews we created already (when an event edit comes in to update the same tile)
Removes unused paths for getInnerText
Needs further testing around:
I will write unit tests to support this.
Signed-off-by: Michael Telatynski [email protected]