Commits on Nov 29, 2019

1. Ensure read receipts end up with a valid reference to checkUnmounting …

   Fixes element-hq/element-web#11496
   Fixes element-hq/element-web#11385
   Fixes element-hq/element-web#10007
   Fixes element-hq/element-web#9769
   
   React does (kinda) bind `this._isUnmounting` for us in the context of the EventTile, but the EventTile then passes the function straight through to the ReadReceiptMarker component, which then binds it in the context of EventTile. This results in `this._mounted` being falsey all the time, preventing the ReadReceiptMarker from hitting the code where it updates rrInfo in its unmount. 
   
   The velocity stuff is smart enough to realize that it has a read receipt and shuffles everything over by one, but when it goes to check the starting height (which will be null/undefined because the RRMarker didn't update it) it assumes it has never seen the receipt before and appends it again - this is what causes some holes/stacking.
   
   By forcefully binding the `this._isUnmounting` function we ensure that the `this._mounted` variable is correctly referenced in the context of the MessagePanel, allowing the RRMarker to update its position, and therefore allowing the velocity behaviour to be consistent.

   

   turt2live committed Nov 29, 2019
   Configuration menu

   • View commit details
   • Copy full SHA for 36f9fab
   • Browse repository at this point

   Copy the full SHA

   36f9fab View commit details

   Browse the repository at this point in the history