Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Attempt to fix soft crash on some pinned events by null guarding member #3581

Merged
merged 1 commit into from
Oct 31, 2019
Merged

Attempt to fix soft crash on some pinned events by null guarding member #3581

merged 1 commit into from
Oct 31, 2019

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Oct 31, 2019 •
edited
Loading

Likely fixes element-hq/element-web#11268 by null-guarding if we are unable to get a member object for the sender of the given event

@t3chguy t3chguy requested a review from a team October 31, 2019 11:31
jryans
jryans approved these changes Oct 31, 2019
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like many other spots assume member might be null, so makes sense to continue here.

@t3chguy t3chguy merged commit db0e643 into develop Oct 31, 2019
@t3chguy t3chguy deleted the t3chguy/pinned_events_soft_crash branch May 25, 2020 18:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jryans jryans jryans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Javascript error - TypeError "e is null" in PinnedEventTile, crashes room
2 participants
@t3chguy @jryans