This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix: stop propagation click handler for <TR> doesn't run #3441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looking at https://buildkite.com/matrix-dot-org/matrix-react-sdk/builds/2365#9df91931-f901-44cb-9372-45afb8058d67 it looks like, at least in the e2e tests in the room directory, the TR click handler for that room is also running and trying to preview the room after clicking the join button. The "can't preview" screen should go away once the join completes though, so can't be the lone cause of the test failure, but having multiple click handlers run when clicking join seems suboptimal in any case. I've tried to reproduce this, and wasn't able though.