This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Persist and maintain identity server in account data #3320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jryans
approved these changes
Aug 19, 2019
| } else { | ||
| MatrixClientPeg.get().setIdentityServerUrl(fullUrl); | ||
| localStorage.removeItem("mx_is_access_token"); // clear token | ||
| localStorage.setItem("mx_is_url", fullUrl); // XXX: Do we still need this? |
There was a problem hiding this comment.
Hmm, I'd file a maintenance issue to consider removing the separately if it really is redundant now.
There was a problem hiding this comment.
turt2live
force-pushed
the
travis/is-account-data
branch
from
78f5645 to
2d4c2b7
Compare
This was referenced Aug 20, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based upon #3317 - changeset is 51946d2
Fixes element-hq/element-web#10094
MSC: matrix-org/matrix-spec-proposals#2230