This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Work with no ID server set #3285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix it so you can't try to invite a room ID to a room
turt2live
approved these changes
Aug 7, 2019
| ); | ||
| } else { | ||
| desc = _t( | ||
| "No Identity Server is configured so you cannot add add an email address in order to " + |
There was a problem hiding this comment.
... unless the HS handles password resets (as is the trend now)
There was a problem hiding this comment.
Yeah, but this is the thing where we don't know if the HS requires an ID server to do password reset or not :(
There was a problem hiding this comment.
i think we should assume the HS does the password reset for security. If someone is running a setup where the IS has to do it, the onus is on them to ensure an IS is set.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Functionality is broken down by commit so may be easier to review commit-by-commit
Fixes element-hq/element-web#5921