Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Don't load guest sessions on post-registration login link #3273

Merged
merged 2 commits into from
Aug 2, 2019

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Aug 2, 2019

If guest access was enabled, clicking the login link on the 'registration
completed' page would just load the guest account you had before registering.

Fixes element-hq/element-web#10482

If guest access was enabled, clicking the login link on the 'registration
completed' page would just load the guest account you had before registering.

Fixes element-hq/element-web#10482
@dbkr dbkr requested a review from a team August 2, 2019 10:25
@jryans jryans requested review from jryans and removed request for a team August 2, 2019 11:12
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, but consider the options object tweak. 😁

src/Lifecycle.js Outdated Show resolved Hide resolved
@dbkr dbkr requested a review from jryans August 2, 2019 15:45
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, seems reasonable! 😁

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Registering with an email and logging in on the original tab did not replace my account
2 participants