This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Move history with alt up/down regardless of where selection is #3254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <[email protected]>
|
There was a reason why we didn't support this before, but I can't remember and can't find where we had the discussion. I think it was @jryans that led that discussion? |
|
Hmm, I can't recall leading something like that... I would defer to @lampholder and @bwindels, as they've been thinking about the editor most recently. |
|
I updated the issue for this to clarify that we're blocked on a decision for how this should work. |
|
@lampholder reviewed during the standup, and suggests we proceed making a change here and watch out for feedback in case any one is negatively affected by the behaviour change. |
turt2live
approved these changes
Jul 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#10325
Has additional niceness that your selection gets persisted too, so you can refer back to an older message than return to your in-progress one without your caret being reset.
Signed-off-by: Michael Telatynski [email protected]