Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Don't show remove button for original event in edit history #3235

Merged
merged 1 commit into from
Jul 18, 2019

Conversation

bwindels
Copy link
Contributor

@bwindels bwindels commented Jul 18, 2019

the latest synapse fixes will redact relations when the base event is redacted. With this, if a user tries to redact the first message in the edit history, he would redact not only the first item in the history, but the whole message. This is not what one would reasonably expect given the UX, so disable it for now.

@bwindels bwindels requested a review from a team July 18, 2019 12:16
@bwindels bwindels added the X-Release-Blocker This affects the current release cycle and must be solved for a release to happen label Jul 18, 2019
@jryans jryans requested review from jryans and removed request for a team July 18, 2019 13:27
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, seems like a reasonable fix to me! 😁

@jryans jryans merged commit 6c6300e into develop Jul 18, 2019
@jryans jryans changed the title dont show remove button for original event in edit history Don't show remove button for original event in edit history Jul 18, 2019
@jryans
Copy link
Collaborator

jryans commented Jul 18, 2019

Merged to React SDK 1.4.0 release branch in #3236

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
X-Release-Blocker This affects the current release cycle and must be solved for a release to happen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants