Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Allow diplayed reaction values to contain anything #3186

Merged
merged 2 commits into from
Jul 5, 2019

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented Jul 5, 2019

This removes the requirement that reactions be a single emoji value. As a compromise to keep some amount of visual sanity, the width is clamped to be at most 100px.

2019-07-05 at 16 16

Fixes element-hq/element-web#10256

@jryans jryans requested a review from a team July 5, 2019 15:20
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yaay :D

@jryans jryans merged commit 74431fe into develop Jul 5, 2019
@Cadair
Copy link
Contributor

Cadair commented Jul 5, 2019

Thank you everyone :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please reinstate the ability to react with non-unicode keys
3 participants