Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add AccessibleTooltipButton and use it for RoomSubList buttons #3165

Merged
merged 4 commits into from
Jul 2, 2019

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jun 30, 2019

Fixes element-hq/element-web#9249

9249

Signed-off-by: Michael Telatynski [email protected]

@t3chguy t3chguy requested a review from a team June 30, 2019 10:01
…ithub.com:matrix-org/matrix-react-sdk into t3chguy/tooltip_accessible_button
@jryans jryans requested a review from nadonomy July 2, 2019 09:16
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great code-wise! 😁

Since there wasn't a reply from @nadonomy on the issue, I think we should double-check with him first before merging this. (I requested his review here.)

src/components/views/elements/AccessibleTooltipButton.js Outdated Show resolved Hide resolved
@nadonomy
Copy link
Contributor

nadonomy commented Jul 2, 2019

This looks great! Looking forward to using these more everywhere.

@jryans jryans merged commit a4587c5 into develop Jul 2, 2019
@t3chguy t3chguy deleted the t3chguy/tooltip_accessible_button branch April 27, 2020 18:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip on the buttons "start a chat" and "join a room"
3 participants