This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
On User.avatarUrl and User.displayName update top left menu #3157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Telatynski <[email protected]>
|
This used to work, and it used to work in settings pre-1.0 - what changed? Do presence-disabled servers still send self-presence down sync? |
|
So this seems like something is awry with Synapse, even on a presence-enabled server it does not work, a self-presence is received without the extra keys as specified by https://matrix.org/docs/spec/client_server/r0.5.0#events-on-change-of-profile-information |
turt2live
suggested changes
Nov 25, 2019
| this.setState({ | ||
| profileInfo: { | ||
| ...this.state.profileInfo, | ||
| avatarUrl: user.avatarUrl, |
There was a problem hiding this comment.
we should be sanity checking that this is even the right user...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So annoyingly this event in js-sdk seems like it'll only work on presence-enabled HSes:
https://github.com/matrix-org/matrix-js-sdk/blob/18655421923506225b12448d386db881c54edae0/src/models/user.js#L87-L94
Fixes element-hq/element-web#8570
Signed-off-by: Michael Telatynski [email protected]