Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Exclude chrome in ua from safari version check for colr support #3038

Merged
merged 2 commits into from
May 29, 2019
Merged

Exclude chrome in ua from safari version check for colr support #3038

merged 2 commits into from
May 29, 2019

Conversation

bwindels
Copy link
Contributor

Follow-up for #3034

jryans
jryans approved these changes May 29, 2019
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working in Chrome, Safari, and Firefox on macOS. 😅

src/utils/FontManager.js Show resolved Hide resolved
@bwindels
Copy link
Contributor Author

e2e tests failed for some unrelated reason, merging.

@bwindels bwindels merged commit d34d5f1 into develop May 29, 2019
@jryans jryans mentioned this pull request May 29, 2019
Merged
@jryans jryans added the X-Release-Blocker This affects the current release cycle and must be solved for a release to happen label May 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jryans jryans jryans approved these changes

Assignees
No one assigned
Labels
X-Release-Blocker This affects the current release cycle and must be solved for a release to happen
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwindels @jryans