Custom notification sounds for rooms

src/Notifier.js

@@ -96,10 +96,51 @@ const Notifier = {
         }
     },
 
-    _playAudioNotification: function(ev, room) {
-        const e = document.getElementById("messageAudio");
-        if (e) {
-            e.play();
+    getSoundForRoom: async function(roomId) {
+        // We do no caching here because the SDK caches the event content
+        // and the browser will cache the sound.
+        let content = SettingsStore.getValue("notificationSound", roomId);
+        if (!content) {
+            content = SettingsStore.getValue("notificationSound");
+            if (!content) {
+                return null;
+            }
+        }
+
+        if (!content.url) {
+            console.warn(`${roomId} has custom notification sound event, but no url key`);
+            return null;
+        }
+
+        return {
+            url: MatrixClientPeg.get().mxcUrlToHttp(content.url),
+            name: content.name,
+            type: content.type,
+            size: content.size,
+        };
+    },
+
+    _playAudioNotification: async function(ev, room) {
+        const sound = SettingsStore.isFeatureEnabled("feature_notification_sounds") ? await this.getSoundForRoom(room.roomId) : null;
+        console.log(`Got sound ${sound && sound.name || "default"} for ${room.roomId}`);
+        // XXX: How do we ensure this is a sound file and not going to be exploited?
+        try {
+            const selector = document.querySelector(sound ? `audio[src='${sound.url}']` : "#messageAudio");
+            let audioElement = selector;
+            if (!selector) {
+                if (!sound) {
+                    console.error("Tried to play alert sound but missing #messageAudio");
+                    return;
+                }
+                audioElement = new Audio(sound.url);
+                if (sound.type) {
+                    audioElement.type = sound.type;
+                }
+                document.body.appendChild(audioElement);
+            }
+            audioElement.play();
+        } catch (ex) {
+            console.warn("Caught error when trying to fetch room notification sound:", ex);
         }
     },
 

src/components/views/dialogs/RoomSettingsDialog.js

@@ -22,8 +22,10 @@ import AdvancedRoomSettingsTab from "../settings/tabs/room/AdvancedRoomSettingsT
 import RolesRoomSettingsTab from "../settings/tabs/room/RolesRoomSettingsTab";
 import GeneralRoomSettingsTab from "../settings/tabs/room/GeneralRoomSettingsTab";
 import SecurityRoomSettingsTab from "../settings/tabs/room/SecurityRoomSettingsTab";
+import NotificationSettingsTab from "../settings/tabs/room/NotificationSettingsTab";
 import sdk from "../../../index";
 import MatrixClientPeg from "../../../MatrixClientPeg";
+import SettingsStore from '../../../settings/SettingsStore';
 
 export default class RoomSettingsDialog extends React.Component {
     static propTypes = {
@@ -49,6 +51,15 @@ export default class RoomSettingsDialog extends React.Component {
             "mx_RoomSettingsDialog_rolesIcon",
             <RolesRoomSettingsTab roomId={this.props.roomId} />,
         ));
+
+        if (SettingsStore.isFeatureEnabled("feature_notification_sounds")) {
+            tabs.push(new Tab(
+                _td("Notifications"),
+                "mx_RoomSettingsDialog_rolesIcon",
+                <NotificationSettingsTab roomId={this.props.roomId} />,
+            ));
+        }
+
         tabs.push(new Tab(
             _td("Advanced"),
             "mx_RoomSettingsDialog_warningIcon",

src/components/views/settings/tabs/room/NotificationSettingsTab.js

@@ -0,0 +1,136 @@
+/*
+Copyright 2019 New Vector Ltd
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+import React from 'react';
+import PropTypes from 'prop-types';
+import {_t} from "../../../../../languageHandler";
+import MatrixClientPeg from "../../../../../MatrixClientPeg";
+import AccessibleButton from "../../../elements/AccessibleButton";
+import Notifier from "../../../../../Notifier";
+import SettingsStore from '../../../../../settings/SettingsStore';
+
+export default class NotificationsSettingsTab extends React.Component {
+    static propTypes = {
+        roomId: PropTypes.string.isRequired,
+        closeSettingsFn: PropTypes.func.isRequired,
+    };
+
+    constructor() {
+        super();
+
+        this.state = {
+            currentSound: "default",
+            uploadedFile: null,
+        };
+    }
+
+    componentWillMount() {
+        Notifier.getSoundForRoom(this.props.roomId).then((soundData) => {
+            if (!soundData) {
+                return;
+            }
+            this.setState({currentSound: soundData.name || soundData.url});
+        });
+    }
+
+    _onSoundUploadChanged(e) {
+        if (!e.target.files || !e.target.files.length) {
+            this.setState({
+                uploadedFile: null,
+            });
+            return;
+        }
+
+        const file = e.target.files[0];
+        this.setState({
+            uploadedFile: file,
+        });
+    }
+
+    async _saveSound(e) {
+        e.stopPropagation();
+        e.preventDefault();
+        if (!this.state.uploadedFile) {
+            return;
+        }
+        let type = this.state.uploadedFile.type;
+        if (type === "video/ogg") {
+            // XXX: I've observed browsers allowing users to pick a audio/ogg files,
+            // and then calling it a video/ogg. This is a lame hack, but man browsers
+            // suck at detecting mimetypes.
+            type = "audio/ogg";
+        }
+        const url = await MatrixClientPeg.get().uploadContent(
+            this.state.uploadedFile, {
+                type,
+            },
+        );
+
+        await SettingsStore.setValue(
+            "notificationSound",
+            this.props.roomId,
+            "room-account",
+            {
+                name: this.state.uploadedFile.name,
+                type: type,
+                size: this.state.uploadedFile.size,
+                url,
+            },
+        );
+
+        this.setState({
+            uploadedFile: null,
+            uploadedFileUrl: null,
+            currentSound: this.state.uploadedFile.name,
+        });
+    }
+
+    _clearSound(e) {
+        e.stopPropagation();
+        e.preventDefault();
+        SettingsStore.setValue("notificationSound", this.props.roomId, "room-account", null);
+
+        this.setState({
+            currentSound: "default",
+        });
+    }
+
+    render() {
+        return (
+            <div className="mx_SettingsTab">
+                <div className="mx_SettingsTab_heading">{_t("Notifications")}</div>
+                <div className='mx_SettingsTab_section mx_SettingsTab_subsectionText'>
+                    <span className='mx_SettingsTab_subheading'>{_t("Sounds")}</span>
+                    <div>
+                        <span>{_t("Custom Notification Sounds")}: <code>{this.state.currentSound}</code></span>
+                    </div>
+                    <div>
+                        <h3>{_t("Set a new custom sound")}</h3>
+                        <form onSubmit={this._saveSound.bind(this)} autoComplete={false} noValidate={true}>
+                            <input type="file" onChange={this._onSoundUploadChanged.bind(this)} accept="audio/*" />
+                            <AccessibleButton onClick={this._saveSound.bind(this)} kind="primary" disabled={!this.state.uploadedFile}>
+                                {_t("Save")}
+                            </AccessibleButton>
+                        </form>
+                        <AccessibleButton onClick={this._clearSound.bind(this)} kind="primary">
+                                {_t("Reset to default sound")}
+                        </AccessibleButton>
+                    </div>
+                </div>
+            </div>
+        );
+    }
+}

src/i18n/strings/en_EN.json

@@ -1618,5 +1618,9 @@
     "If you didn't remove the recovery method, an attacker may be trying to access your account. Change your account password and set a new recovery method immediately in Settings.": "If you didn't remove the recovery method, an attacker may be trying to access your account. Change your account password and set a new recovery method immediately in Settings.",
     "Failed to set direct chat tag": "Failed to set direct chat tag",
     "Failed to remove tag %(tagName)s from room": "Failed to remove tag %(tagName)s from room",
-    "Failed to add tag %(tagName)s to room": "Failed to add tag %(tagName)s to room"
+    "Failed to add tag %(tagName)s to room": "Failed to add tag %(tagName)s to room",
+    "Sounds": "Sounds",
+    "Custom Notification Sounds": "Notification sound",
+    "Set a new custom sound": "Set a new custom sound",
+    "Reset to default sound": "Reset to default sound"
 }

src/settings/Settings.js

@@ -26,6 +26,7 @@ import ThemeController from './controllers/ThemeController';
 
 // These are just a bunch of helper arrays to avoid copy/pasting a bunch of times
 const LEVELS_ROOM_SETTINGS = ['device', 'room-device', 'room-account', 'account', 'config'];
+const LEVELS_ROOM_OR_ACCOUNT = ['room-account', 'account'];
 const LEVELS_ROOM_SETTINGS_WITH_ROOM = ['device', 'room-device', 'room-account', 'account', 'config', 'room'];
 const LEVELS_ACCOUNT_SETTINGS = ['device', 'account', 'config'];
 const LEVELS_FEATURE = ['device', 'config'];
@@ -118,6 +119,9 @@ export const SETTINGS = {
         supportedLevels: LEVELS_FEATURE,
         default: false,
     },
+    "feature_notification_sounds": {
+        isFeature: true,
+        displayName: _td("Custom Notification Sounds"),
     "feature_reactions": {
         isFeature: true,
         displayName: _td("React to messages with emoji"),
@@ -321,6 +325,10 @@ export const SETTINGS = {
         default: false,
         controller: new NotificationsEnabledController(),
     },
+    "notificationSound": {
+        supportedLevels: LEVELS_ROOM_OR_ACCOUNT,
+        default: false,
+    },
     "notificationBodyEnabled": {
         supportedLevels: LEVELS_DEVICE_ONLY_SETTINGS,
         default: true,

src/settings/handlers/AccountSettingsHandler.js

@@ -73,6 +73,10 @@ export default class AccountSettingsHandler extends MatrixClientBackedSettingsHa
             return !content['disable'];
         }
 
+        if (settingName === "notificationSound") {
+            return this._getSettings("uk.half-shot.notification.sound");
+        }
+
         // Special case for breadcrumbs
         if (settingName === "breadcrumb_rooms") {
             const content = this._getSettings(BREADCRUMBS_EVENT_TYPE) || {};

src/settings/handlers/RoomSettingsHandler.js

@@ -68,6 +68,10 @@ export default class RoomSettingsHandler extends MatrixClientBackedSettingsHandl
             return !content['disable'];
         }
 
+        if (settingName === "notificationSound") {
+            return this._getSettings(roomId, "uk.half-shot.notification.sound");
+        }
+
         const settings = this._getSettings(roomId) || {};
         return settings[settingName];
     }