This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Remove breadcrumb scroll tolerances and use sensible defaults #2913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes element-hq/element-web#9394 Fixes element-hq/element-web#9400 Numbers chosen based on user feedback. The setting has also been removed because it isn't really needed anymore.
jryans
approved these changes
Apr 11, 2019
| // xyThreshold is the amount of horizontal motion required for the component to | ||
| // ignore the vertical delta in a scroll. Used to stop trackpads from acting in | ||
| // strange ways. Should be positive. | ||
| const xyThreshold = 0; |
There was a problem hiding this comment.
Interesting choice to keep the variables around when they're both effectively causing no change... I guess it's in case we want to adjust down the road? Would it be simpler to just remove for now?
There was a problem hiding this comment.
It's more to keep the documentation for the behaviour, and to make it slightly easier to tweak down the road if needed.
|
(merging because lint passed but CI is broken due to matrix.org being down - will accept responsibility for breaking develop if it breaks) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#9394
Fixes element-hq/element-web#9400
Numbers chosen based on user feedback. The setting has also been removed because it isn't really needed anymore.