This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add MemberInfo for 3pid invites and support revoking those invites #2843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turt2live
force-pushed
the
travis/cancel-3pid
branch
from
347f6e1 to
0258f61
Compare
jryans
approved these changes
Mar 29, 2019
| @@ -56,7 +56,7 @@ module.exports = React.createClass({ | |||
| user.on("User._unstable_statusMessage", this._onStatusMessageCommitted); | |||
| }, | |||
|
|
|||
| componentWillUmount() { | |||
| componentWillUnmount() { | |||
turt2live
added
the
X-Release-Blocker
We just need to make sure they are structurally sound - actual validation is done by other parties.
|
(re-review because changes are significant enough) |
jryans
approved these changes
Mar 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#625
Fixes element-hq/element-web#6411
Fixes element-hq/element-web#5490
Reviewer: This includes a minor semi-related change because it feels pointless to make it its own PR. It is however a dedicated commit to maintain sensible git history.
The panel is pretty bare bones, but it at least has some information on it:
