Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Explicitly create cryptoStore in React SDK #2814

Merged
merged 1 commit into from
Mar 22, 2019

Conversation

jryans
Copy link
Collaborator

@jryans jryans commented Mar 22, 2019

The React SDK has a client creation path that starts 2 out of 3 stores, but then
leaves the other one for the JS SDK's default value handling.

We'll soon be adding additional code to check the health of stores, so it would
be simpler to follow and think about if we create them all in one place.

The React SDK has a client creation path that starts 2 out of 3 stores, but then
leaves the other one for the JS SDK's default value handling.

We'll soon be adding additional code to check the health of stores, so it would
be simpler to follow and think about if we create them all in one place.
@jryans jryans requested a review from a team March 22, 2019 15:04
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense!

@jryans jryans merged commit 140e0d6 into matrix-org:develop Mar 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants