Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add View Servers in Room to Devtools #2804

Merged
merged 3 commits into from
May 10, 2019
Merged

Add View Servers in Room to Devtools #2804

merged 3 commits into from
May 10, 2019

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Mar 18, 2019

Fixes element-hq/element-web#9194

Signed-off-by: Michael Telatynski [email protected]

image

Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy requested a review from a team March 19, 2019 00:27
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks okay, just a couple code quality things to resolve.

Thanks for taking this on!

constructor(props, context) {
super(props, context);

this.onQuery = this.onQuery.bind(this);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we've since changed how we do this kind of binding. Instead, it is preferred to be represented as:

onQuery = (query) => {
  // do stuff
};

res/css/views/dialogs/_DevtoolsDialog.scss Show resolved Hide resolved
…ix-org/matrix-react-sdk into devtools_serverlist
Signed-off-by: Michael Telatynski <[email protected]>
@t3chguy t3chguy requested review from turt2live and a team May 9, 2019 21:31
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks!

@turt2live turt2live merged commit 3161682 into develop May 10, 2019
@t3chguy t3chguy deleted the devtools_serverlist branch May 25, 2020 18:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/devtools feature to list hosts in a room.
2 participants