This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Restore Field value getter for RegistrationForm
#2790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When working on the `Field` validation support, I thought `RegistrationForm`'s refs would be okay to leave as is, but I missed that they also depended on the value getter. For the moment, it's quicker to temporarily revive the value getter to get registration working. Fixes element-hq/element-web#9171
|
Let's get registration moving again, merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on the
Fieldvalidation support, I thoughtRegistrationForm'srefs would be okay to leave as is, but I missed that they also depended on the
value getter.
For the moment, it's quicker to temporarily revive the value getter to get
registration working. A better fix will happen over in element-hq/element-web#9172.
Fixes element-hq/element-web#9171