This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Remove unnecessary ref from Stickerpicker #2718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is a ref=target in the call to render AccessibleButton for the hide stickers button. This ref is not present in the show case. When clicking the stickerpicker show button, React gives a warning: > Warning: Stateless function components cannot be given refs > (See ref "target" in AccessibleButton created by Stickerpicker). > Attempts to access this ref will fail. Removed the ref. Stickerpicker hide/show still works fine, no warning. Signed-off-by: Jason Robinson <[email protected]>
bwindels
approved these changes
Feb 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a ref=target in the call to render AccessibleButton for
the hide stickers button. This ref is not present in the show case.
When clicking the stickerpicker show button, React gives a warning:
Removed the ref. Stickerpicker hide/show still works fine, no warning.
Signed-off-by: Jason Robinson [email protected]