This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Add a bit of safety around reading events for room settings #2648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jryans
reviewed
Feb 15, 2019
| @@ -116,7 +116,8 @@ export default class RolesRoomSettingsTab extends React.Component { | |||
| _onPowerLevelsChanged = (value, powerLevelKey) => { | |||
| const client = MatrixClientPeg.get(); | |||
| const room = client.getRoom(this.props.roomId); | |||
| let plContent = room.currentState.getStateEvents('m.room.power_levels', '').getContent() || {}; | |||
| const plEvent = room.currentState.getStateEvents('m.room.power_levels', ''); | |||
There was a problem hiding this comment.
Should the JS SDK instead return a dummy object so that the methods still work without testing for them everywhere? This seems like it will get quite annoying to remember to do this everywhere.
There was a problem hiding this comment.
Probably not as that could easily break things that aren't Riot.
There was a problem hiding this comment.
Okay, seems fine to go with this for now at least.
jryans
approved these changes
Feb 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#8530