Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

fix UnknownDeviceDialog layout #2558

Merged
merged 1 commit into from
Feb 1, 2019
Merged

fix UnknownDeviceDialog layout #2558

merged 1 commit into from
Feb 1, 2019

Conversation

bwindels
Copy link
Contributor

@bwindels bwindels commented Feb 1, 2019

@bwindels bwindels requested a review from a team February 1, 2019 17:17
jryans
jryans approved these changes Feb 1, 2019
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better now, thanks! 😁

Does it work well at small widths too?

@bwindels
Copy link
Contributor Author

bwindels commented Feb 1, 2019

Looks much better now, thanks! grin

Does it work well at small widths too?

the dialog is fixed in width, so shouldn't matter.

Note that this is not the redesigned dialog, just a fix for an earlier regression ...

@bwindels bwindels merged commit 62f59f8 into develop Feb 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jryans jryans jryans approved these changes

Assignees

@bwindels bwindels

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bwindels @jryans