Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix exception while saving room settings #2555

Merged
merged 1 commit into from
Feb 1, 2019

Conversation

bwindels
Copy link
Contributor

@bwindels bwindels commented Feb 1, 2019

I got the following exception while trying to save the room settings:

Uncaught TypeError: this.refs.url_preview_settings.saveSettings is not a function
    at Object.saveUrlPreviewSettings (http://localhost:8080/bundles/_dev_/bundle.js:129413:47)
    at Object._calcSavePromises (http://localhost:8080/bundles/_dev_/bundle.js:129366:23)
    at http://localhost:8080/bundles/_dev_/bundle.js:129296:50
From previous event:
    at Object.save (http://localhost:8080/bundles/_dev_/bundle.js:129295:41)
    at Object.onSettingsSaveClick (http://localhost:8080/bundles/_dev_/bundle.js:79028:33)
    at

saveSettings was indeed removed, which I guess is intentional as SettingsFlag seems to save itself by default on change? Not sure though, @turt2live ?

@bwindels bwindels requested a review from turt2live February 1, 2019 10:27
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks right. Merging in the event we need to revert #2559 and want working settings.

This view otherwise won't survive very long though.

@turt2live turt2live merged commit 7ff59c8 into develop Feb 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants