Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Support selects on Field #2484

Merged
merged 2 commits into from
Jan 23, 2019
Merged

Support selects on Field #2484

merged 2 commits into from
Jan 23, 2019

Conversation

turt2live
Copy link
Member

Luckily, the styling is copy/paste capable.

image

@turt2live
Support selects on Field
f0e8182 
Luckily, the styling is copy/paste capable.
@turt2live turt2live requested a review from a team January 23, 2019 02:27
@jryans jryans self-assigned this Jan 23, 2019
jryans
jryans suggested changes Jan 23, 2019
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good idea, but I think we need a few tweaks first.

src/components/views/elements/Field.js Show resolved Hide resolved
res/css/views/elements/_Field.scss Outdated Show resolved Hide resolved
@jryans jryans assigned turt2live and unassigned jryans Jan 23, 2019
@turt2live turt2live requested a review from jryans January 23, 2019 03:04
@turt2live turt2live assigned jryans and unassigned turt2live Jan 23, 2019
jryans
jryans approved these changes Jan 23, 2019
View reviewed changes
Copy link
Collaborator

@jryans jryans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks reasonable to me! 😁

@turt2live turt2live merged commit b83227c into experimental Jan 23, 2019
@turt2live turt2live deleted the travis/select-field branch January 23, 2019 03:13
@jryans jryans assigned turt2live and unassigned jryans Jan 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jryans jryans jryans approved these changes

Assignees

@turt2live turt2live

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@turt2live @jryans