-
-
Notifications
You must be signed in to change notification settings - Fork 829
Conversation
The label moves into the border on focus and after being filled. A valid color is applied to the label and input border. Other states like invalid can be added later as needed. Adapted from @ara4n's experiment into a React component with a CSS only approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some variables might need to be added to riot-web's status theme as well (errors might not crop up until someone uses the component, though)
Co-Authored-By: jryans <[email protected]>
These days, such errors seem to appear at build time. (Perhaps that's new as of the content hashed image work, unsure...) In any case, the Status theme root imports the light theme's |
so it does... I wonder why I've never had luck with that... I guess it's fine though - it seems to build fine |
woo, awesome :) thank you! i don’t believe we need to worry about keeping the status theme working with Experimental. the demo gif here highlights that we need to distinguish “focused” from “valid” somehow; need input from @nadonomy here |
@nadonomy okay - so how do we distinguish between unfocused-and-valid and focused-and-valid? as the current zeplin implies they should both be green atm... |
@ara4n just updated the comp in Zeplin to show what I'm thinking: https://zpl.io/VDqejkr |
Opened #2468 for the label alignment and new focused color. |
The label moves into the border on focus and after being filled. A valid color
is applied to the label and input border. Other states like invalid can be added
later as needed.
Adapted from @ara4n's experiment into a React component with a CSS only
approach.