This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Different dialog for new trusted backup #2435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the 'new recovery method' into two cases: one where the new recovery method isn't trusted and you need to verify the device, and another where it is and the client is using it (where it's more of an FYI). element-hq/element-web#8069
jryans
reviewed
Jan 11, 2019
| let haveNewVersion; | ||
| let newVersionInfo; | ||
| // if key backup is still enabled, there must be a new backup in place | ||
| if (MatrixClientPeg.get().getKeyBackupEnabled()) { |
There was a problem hiding this comment.
If key backup is enabled here, we go to the "New Recovery Method" dialog without setting newVersionInfo to a value, but that's marked isRequired in propTypes. Should it change to not required?
jryans
approved these changes
Jan 11, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the 'new recovery method' into two cases: one where the new
recovery method isn't trusted and you need to verify the device, and
another where it is and the client is using it (where it's more of
an FYI).
Also base the choice of which dialog to use on polling to see if there is a new one (because M_NOT_FOUND just means the one has gone away: there may or may not be a new version.
element-hq/element-web#8069