This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Fix lint errors in MessageComposerInput #2423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and remove from ignored files Missed a load of the async arrows functions when changing them because they were in the ignored files, so trying to chip away at this. A lot of these were unused imports / variables. Probably the only interesting one was a 'this' in a non-member function which I've moved to be a member function.
jryans
approved these changes
Jan 10, 2019
| @@ -868,7 +861,7 @@ export default class MessageComposerInput extends React.Component { | |||
| return true; | |||
| } | |||
|
|
|||
| const newState: ?Value = null; | |||
| //const newState: ?Value = null; | |||
There was a problem hiding this comment.
The block of code that uses it is commented below, so I figured it should be left as long as the commented out block is there :/
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and remove from ignored files
Missed a load of the async arrows functions when changing them because
they were in the ignored files, so trying to chip away at this.
A lot of these were unused imports / variables. Probably the only
interesting one was a 'this' in a non-member function which I've moved
to be a member function.