Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Add slash command for changing room name #2401

Merged
merged 2 commits into from
Jan 4, 2019
Merged

Add slash command for changing room name #2401

merged 2 commits into from
Jan 4, 2019

Conversation

christopherjmedlin
Copy link
Contributor

/name <name> will change the room's name to whatever <name> is.

(element-hq/element-web#7774)

@turt2live turt2live changed the base branch from develop to experimental January 3, 2019 23:57
@turt2live turt2live requested a review from a team January 3, 2019 23:57
@t3chguy
Copy link
Member

t3chguy commented Jan 4, 2019

Looks plausible, not sure whether name isn't too ambiguous though

@christopherjmedlin
Copy link
Contributor Author

/roomname perhaps?

dbkr
dbkr reviewed Jan 4, 2019
View reviewed changes
Copy link
Member

@dbkr dbkr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks plausible, but yeah, roomname may be less ambiguous.

t3chguy
t3chguy approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jryans jryans merged commit e6b6b46 into matrix-org:experimental Jan 4, 2019
@bmarty bmarty mentioned this pull request Jan 10, 2019
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dbkr dbkr dbkr left review comments

@t3chguy t3chguy t3chguy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@christopherjmedlin @t3chguy @dbkr @jryans