Standardize errors about localpart structure

[turt2live]

Fixes element-hq/element-web#5833

This also includes changing some Jira references that aren't searchable anymore, and a thing to replace the spinner on the SetMxidDialog as per element-hq/element-web#5833 (comment)

[jryans]

Thanks, the change looks good. 😁

Please investigate the CI failure before merging... E2E tests seem to fail on the first step. Is the test checking from some of this text?

[turt2live]

Looks like the regex is failing on the login page and that's causing it to not continue normally.

Going to have to spend some time figuring this one out though:

SAFE_LOCALPART_REGEX.test("lowercase")
true
!SAFE_LOCALPART_REGEX.test("lowercase")
true

[jryans]

Going to have to spend some time figuring this one out though:

SAFE_LOCALPART_REGEX.test("lowercase")
true
!SAFE_LOCALPART_REGEX.test("lowercase")
true

Yikes... I guess parens do the right thing:

!(SAFE_LOCALPART_REGEX.test("lowercase"))
false

but yeah... that's pretty strange. 😰

[jryans]

Oh wait, the test method is stateful somehow...?

SAFE_LOCALPART_REGEX.test("lowercase")
true
SAFE_LOCALPART_REGEX.test("lowercase")
false
SAFE_LOCALPART_REGEX.test("lowercase")
true
SAFE_LOCALPART_REGEX.test("lowercase")
false

[jryans]

Ah, it's the global flag on the regex. If you remove that, it works:

const SAFE_LOCALPART_REGEX = /^[a-z0-9=_\-./]+$/;
undefined
SAFE_LOCALPART_REGEX.test("lowercase")
true
SAFE_LOCALPART_REGEX.test("lowercase")
true
SAFE_LOCALPART_REGEX.test("lowercase")
true

[turt2live]

Huh, I didn't realize that the expression actually stores state (and that the global flag interferes that badly). Thanks for taking a look into it - I've committed the change.