This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Avoid preserving HS url at logout #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I was talking to Matthew about this the other day, we couldn't think of a good reason why we should preserve the HS URL at logout. It introduces the problem that, if a client is redirected after login as per MSC1730, and then you log out, you'll then get a login screen for the wrong server. So basically there's no reason to have an mx_hs_url/mx_is_url without an access token, and we can remove the stuff which preserves it, and the stuff that attempts to restore it.
|
well this seems to be failing an integ test which deliberately tests the thing I'm trying to change here. If people agree that this is sane behaviour then I can investigate how to update the tests. |
bwindels
approved these changes
Dec 11, 2018
richvdh
added a commit
to element-hq/element-web
that referenced
this pull request
Dec 11, 2018
See the react-sdk PR for some context.
bwindels
added a commit
to element-hq/element-web
that referenced
this pull request
Dec 11, 2018
Update the tests to match matrix-org/matrix-react-sdk#2340
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was talking to Matthew about this the other day, we couldn't think of a
good reason why we should preserve the HS URL at logout. It introduces the
problem that, if a client is redirected after login as per MSC1730, and then
you log out, you'll then get a login screen for the wrong server.
So basically there's no reason to have an mx_hs_url/mx_is_url without an access
token, and we can remove the stuff which preserves it, and the stuff that
attempts to restore it.