Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Fix empty lightbox when there is no avatarUrl #2314

Merged
merged 2 commits into from
Feb 1, 2019
Merged

Fix empty lightbox when there is no avatarUrl #2314

merged 2 commits into from
Feb 1, 2019

Conversation

aaronraimist
Copy link
Contributor

turt2live
turt2live suggested changes Dec 6, 2018
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Can we also disable the cursor effect? It feels like pressing a dead button now, which is almost worse than getting useless results.

@aaronraimist
Copy link
Contributor Author

Honestly not sure where that happens in the code. I assume the proper fix for this is somewhere in BaseAvatar.js (the highlight effect also happens when you click on a user with no avatar)

@turt2live
Copy link
Member

The clickable part is probably a pointer: cursor somewhere in the CSS. Might be able to trick the browser by sticking disabled on the avatar element itself.

@aaronraimist aaronraimist force-pushed the empty-url-empty-lightbox branch from 8d10e02 to cd11d07 Compare January 29, 2019 22:06
@aaronraimist aaronraimist changed the base branch from develop to experimental January 29, 2019 22:06
@aaronraimist aaronraimist force-pushed the empty-url-empty-lightbox branch from cd11d07 to 52ebba9 Compare January 29, 2019 22:07
@aaronraimist
Copy link
Contributor Author

aaronraimist commented Jan 29, 2019 •
edited
Loading

Finally got back to this. This seems to be a better way to do it so that the button is actually disabled.

@turt2live turt2live self-requested a review January 29, 2019 22:13
@aaronraimist aaronraimist changed the base branch from experimental to develop January 30, 2019 16:09
turt2live
turt2live approved these changes Feb 1, 2019
View reviewed changes
Copy link
Member

@turt2live turt2live left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@turt2live turt2live merged commit 0ecaa2e into matrix-org:develop Feb 1, 2019
@turt2live turt2live mentioned this pull request Feb 1, 2019
Closed
@aaronraimist aaronraimist deleted the empty-url-empty-lightbox branch February 1, 2019 18:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@turt2live turt2live turt2live approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronraimist @turt2live