This repository has been archived by the owner on Sep 11, 2024. It is now read-only.
Factor out common login code #2307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes the duplication between the various points where we send off a login request and parse the response.
turt2live
approved these changes
Nov 28, 2018
src/Login.js
Outdated
| * as a MatrixClientCreds | ||
| * | ||
| * @param {string} hs the base url of the Homeserver used to log in. | ||
| * @param {string} is the default identity server |
There was a problem hiding this comment.
I assume URL?
It might also be good to have these be named hsUrl and isUrl for self-documentation reasons.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the duplication between the various points where we send off a login
request and parse the response.