Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

Support routing matrix.to links to joinable rooms #2250

Merged
merged 16 commits into from
Oct 26, 2018
Merged

Support routing matrix.to links to joinable rooms #2250

merged 16 commits into from
Oct 26, 2018

Commits on Oct 19, 2018

  1. Support parsing matrix.to links in the timeline with ?via= in them 

    This ends up being translated to ?server_name= in the matrix-js-sdk, although that has a bug at the time of writing. It converts `server_name: ['a', 'b']` to `?server_name=a,b` instead of `?server_name=a&server_name=b`

For reference: the `viaServers` option is routed through the 'join_room' action to RoomViewStore#_joinRoom which is passed directly to the js-sdk http-api#joinRoom function.

Next steps:
* Fix the js-sdk parsing
* Make the SDK generate matrix.to links with ?via=
    @turt2live
    turt2live committed Oct 19, 2018
    Configuration menu
    Copy the full SHA
    7383133 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2018

  1. Merge branch 'develop' into travis/permalink-routing

    @turt2live
    turt2live committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    d7367a7 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/develop' into travis/permalink-r… 

    …outing
    @turt2live
    turt2live committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    6ee495b View commit details
    Browse the repository at this point in the history

  3. Install memfs because webpack is made of fail

    @turt2live
    turt2live committed Oct 24, 2018
    Configuration menu
    Copy the full SHA
    a878212 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2018

  1. Pick servers for ?via on matrix.to links based on some heuristics

    @turt2live
    turt2live committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    e8cb636 View commit details
    Browse the repository at this point in the history

  2. Fix Karma/Webpack so it can build the tests

    @turt2live
    turt2live committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    54ff5d8 View commit details
    Browse the repository at this point in the history

  3. Fix the tests so they actually test something

    @turt2live
    turt2live committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    b9bfbdc View commit details
    Browse the repository at this point in the history

  4. Add hostname sanity tests 

    In the event someone changes how the hostname parsing works.
    @turt2live
    turt2live committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    43980ad View commit details
    Browse the repository at this point in the history

  5. Fix the server candidate picker to actually work 

    Tests do wonders.
    @turt2live
    turt2live committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    5209496 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' into travis/permalink-routing

    @turt2live
    turt2live committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    d58ff90 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2018

  1. Merge branch 'develop' into travis/permalink-routing

    @turt2live
    turt2live committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    ea8a37f View commit details
    Browse the repository at this point in the history

  2. Maybe fix UserSettings?

    @turt2live
    turt2live committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    ef8c924 View commit details
    Browse the repository at this point in the history

  3. Appease the linter

    @turt2live
    turt2live committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    c389540 View commit details
    Browse the repository at this point in the history

  4. Move the max candidates constant out of the function

    @turt2live
    turt2live committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    d802ee0 View commit details
    Browse the repository at this point in the history

  5. Don't mention that matrix.org is likely to be popular 

    This is untrue for quite a few real scenarios, including private federations and a ton of rooms.
    @turt2live
    turt2live committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    3734c8a View commit details
    Browse the repository at this point in the history

  6. Clarify why we pick popular servers over the one that created the room

    @turt2live
    turt2live committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    0857e2c View commit details
    Browse the repository at this point in the history