Skip to content
This repository has been archived by the owner on Sep 11, 2024. It is now read-only.

add null-guard for stickerpickerWidget in StickerPicker #2057

Merged
merged 1 commit into from
Jul 13, 2018

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jul 13, 2018

Should fix

Stickerpicker.js:169 Uncaught TypeError: Cannot read property 'id' of undefined
    at Stickerpicker._sendVisibilityToWidget (Stickerpicker.js:169)
    at Stickerpicker.componentDidUpdate (Stickerpicker.js:113)
    at measureLifeCyclePerf (ReactCompositeComponent.js:73)
    at ReactCompositeComponent.js:726
    at CallbackQueue.notifyAll (CallbackQueue.js:74)
    at ReactReconcileTransaction.close (ReactReconcileTransaction.js:78)
    at ReactReconcileTransaction.closeAll (Transaction.js:207)
    at ReactReconcileTransaction.perform (Transaction.js:154)
    at ReactUpdatesFlushTransaction.perform (Transaction.js:141)
    at ReactUpdatesFlushTransaction.perform (ReactUpdates.js:87)
    at Object.flushBatchedUpdates (ReactUpdates.js:170)
    at ReactDefaultBatchingStrategyTransaction.closeAll (Transaction.js:207)
    at ReactDefaultBatchingStrategyTransaction.perform (Transaction.js:154)
    at Object.batchedUpdates (ReactDefaultBatchingStrategy.js:60)
    at Object.enqueueUpdate (ReactUpdates.js:198)
    at enqueueUpdate (ReactUpdateQueue.js:22)
    at Object.enqueueSetState (ReactUpdateQueue.js:216)
    at Object.ReactComponent.setState (ReactBaseClasses.js:62)
    at Object.onResize (RoomView.js:1362)

which Erik has found to prevent syncing and cause critical breakage

@t3chguy t3chguy requested a review from a team July 13, 2018 13:25
@ara4n ara4n merged commit ac1f130 into develop Jul 13, 2018
@ara4n
Copy link
Member

ara4n commented Jul 13, 2018

lgtm

@t3chguy t3chguy deleted the t3chguy/null-guard-stickerpicker branch April 27, 2020 18:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants